Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SKIP message when JSON::MaybeXS is not found #1017

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Dec 20, 2024

It's just a test file; we don't need a full dump of the user's @INC.

It's just a test file; we don't need a full dump of the user's @inc.
@jkeenan
Copy link
Contributor Author

jkeenan commented Dec 20, 2024

While examining the latest CPAN release of the Test-Simple distribution today, I had occasion to try to install it against a fresh Perl 5 tarball. I got this message:

t/regression/247_check_ref_bool.t ................ skipped: Need JSON::MaybeXS: Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC entries checked: /home/jkeenan/gitwork/zzzothers/test-more/blib/lib /home/jkeenan/gitwork/zzzothers/test-more/blib/arch /home/jkeenan/testing/blead/lib/perl5/site_perl/5.41.7/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/site_perl/5.41.7 /home/jkeenan/testing/blead/lib/perl5/5.41.7/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/5.41.7 .) at t/regression/247_check_ref_bool.t line 5.

Do we really need a complete dump of the user's @INC? I don't think so. Any user sophisticated enough to install their own CPAN distros will know how to install a module needed for testing if they so desire.

@exodist exodist merged commit eb51ab7 into Test-More:master Dec 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants