Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week4 update idoft - xinyinglyu #1464

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

xinying-7
Copy link
Contributor

Changing status for 28 different lines with evidences written in progress4.md

@xinying-7 xinying-7 changed the title Xinying Lyu week4 week4 update idoft - xinyinglyu Nov 8, 2024
Copy link
Contributor

@darko-marinov darko-marinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your changes on the latest main. You may also want to open several smaller PRs rather than one large PR that will take time to accept.

pr-data.csv Outdated
@@ -4050,7 +4050,7 @@ https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b8756361
https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b87563616ee04,.,org.fluentd.logger.TestFluentLogger.testReconnection,NDOD;UD;NOD,Unmaintained,,last commit on 2019-06-12
https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-engine,net.redpipe.engine.swagger.SwaggerApiTest.checkSwagger,NOD,RepoArchived,,
https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkMail,NOD,RepoArchived,,
https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,Opened,https://github.com/fromage/redpipe/pull/56,
https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,Skipped,https://github.com/FroMage/redpipe/commit/2fc605bc2fad4aadbb3b05282f528a05673df2ca#diff-86139da6bd888a5e7589f89d4f81a426bac99cd8aabab363efb5e338c1158f5bR131,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave Opened as it was and put RepoArchived in the last column (Notes).

pr-data.csv Outdated
@@ -5451,7 +5451,7 @@ https://github.com/pippo-java/pippo,ae898b6c478af7365b04c2f5bf9331abf496b166,pip
https://github.com/pippo-java/pippo,ae898b6c478af7365b04c2f5bf9331abf496b166,pippo-session-parent/pippo-session-mongodb,ro.pippo.session.mongodb.MongoDBSessionDataStorageTest.testSave,NOD,,,
https://github.com/pmd/pmd,bdc08e44fd92380d59cdc50cf9d8dd36e537c369,pmd-core,net.sourceforge.pmd.lang.rule.internal.LatticeRelationTest.testToString,ID,Opened,https://github.com/pmd/pmd/pull/4752,
https://github.com/pmd/pmd,bdc08e44fd92380d59cdc50cf9d8dd36e537c369,pmd-core,net.sourceforge.pmd.renderers.SummaryHTMLRendererTest.testRendererMultiple,ID,Accepted,https://github.com/pmd/pmd/pull/4750,
https://github.com/ppiastucki/recast4j,01d478e190b731d2fe861e3b969b4c8dd04f0ede,detourtilecache,org.recast4j.detour.tilecache.TileCacheTest.testPerformance,NOD,,,
https://github.com/ppiastucki/recast4j,01d478e190b731d2fe861e3b969b4c8dd04f0ede,detourtilecache,org.recast4j.detour.tilecache.TileCacheTest.testPerformance,NOD,MovedToGradle,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in the last column the commit when the project moved to Gradle.

pr-data.csv Outdated
https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit-adapters/rxjava,retrofit2.adapter.rxjava.SingleThrowingTest.responseThrowingInOnSuccessDeliveredToPlugin,NDOD;NOD,,,
https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit,retrofit2.CallTest.cancelOkHttpRequest,NOD,,,
https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit,retrofit2.CallTest.cancelRequest,NDOD;NOD,,,
https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit-adapters/rxjava,retrofit2.adapter.rxjava.CancelDisposeTest.cancelDoesNotDispose,NOD,MovedToGradle,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above -- add commits when the project moved to Gradle. Did you try to run this project with the NonDex Gradle plugin?

pr-data.csv Show resolved Hide resolved
pr-data.csv Outdated
https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginCircuitBreakerTest.shouldOpenCircuit,UD,,,
https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginRetriesTest.shouldInvokeListenersOnRetryableResult,UD,,,
https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginRetriesTest.shouldNotRetryNonIdempotentMethod,UD,,,
https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.RetryAfterDelayFunctionTest.shouldRetryOnDemandWithDynamicDelay,NOD,,,
https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.RetryAfterDelayFunctionTest.shouldRetryOnDemandWithDynamicDelay,NOD,Skipped,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above -- no Skipped here in IDoFT.

@darko-marinov
Copy link
Contributor

Any progress on splitting this PR into multiple? Please let me know if you need some help.

@darko-marinov
Copy link
Contributor

You still need to clean this PR if you want to get some "points".

@xinying-7
Copy link
Contributor Author

please refer to #1597 to see the changes that corrects these issues.

@darko-marinov
Copy link
Contributor

Can you simplify this PR to keep only a few changes that I can easily accept? Then we can look into the other changes in #1597

@xinying-7
Copy link
Contributor Author

I've revised this PR and moved all the changes in #1597 to here , below is the summary of changes:

Changed status to movedToGradle and added evidence for 8 tests in retrofit-adapters/rxjava, plus 1 test in https://github.com/ppiastucki/recast4j, Evidence/log is in progress_4.md.

Changed the status of riptide: org.zalando.riptide.autoconfigure.retry.RetryTest.shouldRetryForAtMostMaxRetriesTimes to MovedOrRenamed. Evidence/log is in progress_4.md.

Changed the status of riptide: org.zalando.riptide.autoconfigure.LogbookCompatibilityTest.shouldUseInterceptors to Deleted. Evidence/log is in progress_4.md.

Removed all the “skipped” status changes.

https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,
The RepoArchived status of this one was already been updated by others so didn't change this line.

@darko-marinov darko-marinov merged commit 565bf8e into TestingResearchIllinois:main Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants