Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update an ID Test to MovedOrRenamed with script #1580

Conversation

Jake-WangZhi
Copy link
Contributor

@Jake-WangZhi Jake-WangZhi commented Dec 6, 2024

Learned and utilized the auto-check-moved-or-rename script to identify the commit for this moved test.

The test were moved in this commit.

I put this test into the test.txt first and copy it and check_moved_or_rename.sh script to the root of the repo I wanna test and I ran this to find the commit.

./check_moved_or_rename.sh

@Jake-WangZhi Jake-WangZhi changed the title Update an ID Test to MovedOrRenamed Update an ID Test to MovedOrRenamed with script Dec 6, 2024
@darko-marinov
Copy link
Contributor

How did you "I put this test into the test.txt"? Can you just grep for the test name? (Why) does the script require the input to be in a file named some way rather than being passed on stdin or as command-line arguments?

@Jake-WangZhi
Copy link
Contributor Author

How did you "I put this test into the test.txt"? Can you just grep for the test name? (Why) does the script require the input to be in a file named some way rather than being passed on stdin or as command-line arguments?

@darko-marinov Yes, I believe we can just use grep to search for tests. However, this script expects an input text file containing all the tests to run, as mentioned in its README. From my understanding, the author likely wanted to keep the terminal cleaner by consolidating the test lines into a text file, making it easier to track what tests were executed. In the terminal, especially with multiple tests, the lines can wrap or get pushed to the next line, potentially creating a block of text that’s hard to read.

@Jake-WangZhi
Copy link
Contributor Author

Jake-WangZhi commented Dec 7, 2024

@darko-marinov Sorry, I just realized I worked on the wrong repo—I was assigned the letter l, but somehow I thought it was i. This repo starts with letter i, which means that I was not supposed to work on this rep. Can we just close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants