Skip to content

Commit

Permalink
Fix bug of workflow editor having smaller size (#2834)
Browse files Browse the repository at this point in the history
## Purpose
Address #2810 #2809 
There was a bug with the current workflow editor workspace where after
page reload, the html element with id="workflow-editor" had an incorrect
size. This caused issues such as operators not being visible on the
lower part of the page and the minimap window changing size.
## Changes
Dispatch "resize" event when workflow editor is loaded to invoke all the
relevant resize handlers.
## Demo
Before (on texera.ics.uci.edu)

![workflow_editor_size_bug_master](https://github.com/user-attachments/assets/a3e5a50b-00ac-4c20-9fdf-afb256e0947c)
After

![workflow_editor_size_bug_branch](https://github.com/user-attachments/assets/7c51624d-bce5-4e6f-adb7-ce4ec54e3137)
  • Loading branch information
sixsage authored and PurelyBlank committed Dec 4, 2024
1 parent d38c4af commit dbf3366
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#workflow-editor-wrapper {
height: 100%;
height: 100vh;
width: 100vw;
}

#workflow-editor {
height: 100%;
height: 100vh;
width: 100vw;
}

::ng-deep #workflow-editor .connection-wrap {
Expand Down
4 changes: 4 additions & 0 deletions core/gui/src/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,7 @@ hr {
.ant-tabs-tabpane {
padding-right: 24px;
}

body {
overflow: hidden;
}

0 comments on commit dbf3366

Please sign in to comment.