Bugfix: Albert load workflow opt #1481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by freezing joint paper until all updates are complete, skipping unnecesarry rendering
...by batching the addition of new operators with one addcells() / resetcells() call
…-load_workflow_opt
ContextManager with RXJS event streams
it now buffers input while the joint graph wrapper is in an async context
accidentally made SyncTexeraGraph listeners asynchronous via createContextAwareStream(jointCellAddStream) . This caused them to not be disabled by this.setSyncTexeraGraph(false); which is commonly used internally to temporarily sidestep synchronization . I've applied the context awareness more specifically to handleLinkBreakpointToolAttachment(), where it's specifically needed.
as an RXJS pipeable operator named bufferWhileAsync. Also moved it inside JointGraphContext
set to protected funcs. Use withContext instead
use "this" instead of classname. allows for method overriding
highlight/unhighlight operations fail unless buffered until the end of joint-graph async context, It is no longer guaranteed that the unhighlight event will be recieved before the element is deleted due to buffering of events. (although such guarantees were never documented)
... if reloadworkflow is called without using async context. This was due to addCells being intrinsically an asynchronous operation that buffers changes to the actual dom Fix was to wrap all addCells contexts in their own async context. This shouldn't harm reload performance, since the workflow is only reloaded when context changes from async to synchronous
…texera into albert-load_workflow_opt
Cause: jointjs refers to DOM when sorting elements by z attribute, However, during async mode, DOM is out of sync with jointjs's internal representation Solution: turn off sorting during async mode
|
Superseded by #1482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: operator links disappear when using version switching feature
Cause:
Solution: