Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable google login in the frontend configuration #3219

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

paulschatt
Copy link
Collaborator

@paulschatt paulschatt commented Jan 18, 2025

Fix #3220

Purpose

Right now, both local and google login are enabled, which might confuse users.

Changes

  1. Introduced googleLogin in environment.default
  2. Added googleLogin to dashboard.component
  3. Hide the Google Login component in dashboard.component.html if googleLogin is false
Bildschirmfoto 2025-01-17 um 17 33 05

Copy link
Collaborator

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulschatt paulschatt marked this pull request as ready for review January 24, 2025 23:13
@paulschatt paulschatt merged commit 3801a0c into master Jan 24, 2025
8 checks passed
@paulschatt paulschatt deleted the schatt-add-flag-disable-google-login branch January 24, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google login cannot be disabled
2 participants