-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Operator Statistics Storage Using Iceberg #3222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
...-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergTableManager.scala
Outdated
Show resolved
Hide resolved
...-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergTableManager.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
@yunyad Add a detailed description for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/ResultTableStatistics.scala
Outdated
Show resolved
Hide resolved
core/workflow-core/src/main/scala/edu/uci/ics/amber/util/IcebergUtil.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/service/ExecutionResultService.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/ResultTableStatistics.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/model/VirtualDocument.scala
Outdated
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/TableStatistics.scala
Outdated
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/TableStatistics.scala
Outdated
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/TableStatistics.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some minors, LGTM!
Please update the PR description to include the general idea of how this implementation is done, and the future PR plans.
This PR handles the storage conversion from the original MongoDB storage to Iceberg for storing execution result statistics. The migration is motivated by the limitations and constraints of MongoDB, and this PR introduces functionality to store runtime statistics using Iceberg.
We store three types of statistical information: min, max, and non-null value counts, if available. For string and boolean types, we do not include min and max values.
Related issue: apache/iceberg#12112