fix: download operators result #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Feb 4, 2025
...mber/src/main/scala/edu/uci/ics/texera/web/model/websocket/request/ResultExportRequest.scala
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/ResultResource.scala
Outdated
Show resolved
Hide resolved
core/gui/src/app/dashboard/service/user/download/download.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/dashboard/service/user/download/download.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # core/amber/src/main/scala/edu/uci/ics/texera/web/service/ResultExportService.scala
bobbai00
requested changes
Feb 18, 2025
core/gui/src/app/dashboard/service/user/download/download.interface.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/dashboard/service/user/download/download.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/workspace/component/result-exportation/result-exportation.component.ts
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/ResultResource.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/service/ResultExportService.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/service/ResultExportService.scala
Show resolved
Hide resolved
bobbai00
approved these changes
Mar 4, 2025
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/ResultResource.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in continuous of PR 3221 to implement download logic in backend.
Export request structure updates
In this PR, we update
ResultExportRequestto include a new variable nameddestination. If its set tolocal, means the user wants to download operators result. Also,operatorIdsis now plural so with one request, multiple operators can be exported (locally or to dataset).Export endpoint updates
In this PR, we update
ResultResourceto supportdestination=local. In this regard, we have two cases:The export to dataset follows the old logic.
Export service updates
In this PR, we update
ResultExportServiceto have two core more new functions:exportOperatorResultAsStream: For local download of a single operator. Streams the data directly.exportOperatorsAsZip: For local download of multiple operators. Zip the output and stream back.Demo video
2025-02-02.14-00-34.mp4