New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabbed content): prevent duplicate ids error #5239

Draft

TomJGooding wants to merge 1 commit into Textualize:main from TomJGooding:fix-tabbed-content-prevent-duplicate-ids-error

+26 −1

Contributor

TomJGooding commented Nov 15, 2024 •

edited

Loading

Fixes #5215.

I've marked this as a draft as I'm not sure if this added _tabs_counter should reflect the Tabs widget?

After looking into this a bit deeper, it seems the Tabs widget already assigns ID's based on a counter. However this counter only increments when the tab ID hasn't been provided.

Should the TabbedContent reflect this setting of ID's? This would make these widgets more consistent, but might be a breaking change.

Please review the following checklist.

Docstrings on all new or modified functions / classes
Updated documentation
Updated CHANGELOG.md (where appropriate)


          fix(tabbed content): prevent duplicate ids error

29c7103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet