Update connect web examples to use latest sdk's #18
Conversation
WalkthroughThe recent updates across several files introduce a new nested Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
connect/sdk/javascript-example/yarn.lockis excluded by!**/*.lockconnect/sdk/react-example/yarn.lockis excluded by!**/*.lock
Files selected for processing (6)
- connect/get_link.js (1 hunks)
- connect/get_link.py (1 hunks)
- connect/sdk/javascript-example/main.js (2 hunks)
- connect/sdk/javascript-example/package.json (1 hunks)
- connect/sdk/react-example/package.json (1 hunks)
- connect/sdk/react-example/src/App.tsx (2 hunks)
Files skipped from review due to trivial changes (2)
- connect/sdk/javascript-example/package.json
- connect/sdk/react-example/package.json
Additional context used
Biome
connect/sdk/react-example/src/App.tsx
[error] 31-38: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
Additional comments not posted (6)
connect/sdk/react-example/src/App.tsx (2)
13-19: The addition of thecustomerInfoobject enhances the structure for user data. Good implementation.
34-35: The adjustment in dimensions from480x640to600x800seems intended to enhance the UI. Please confirm with the UI/UX team if these dimensions align with the design specifications.connect/sdk/javascript-example/main.js (2)
12-18: The addition of thecustomerInfoobject enhances the structure for user data. Good implementation.
37-38: The adjustment in dimensions from480x640to600x800seems intended to enhance the UI. Please confirm with the UI/UX team if these dimensions align with the design specifications.connect/get_link.py (1)
18-23: The addition of thecustomerInfoobject enhances the structure for user data. Good implementation.connect/get_link.js (1)
20-25: The addition of thecustomerInfoobject enhances the structure for user data. Good implementation.
| <button | ||
| onClick={() => | ||
| open({ | ||
| width: 480, | ||
| height: 640, | ||
| width: 600, | ||
| height: 800, | ||
| }) | ||
| } | ||
| > |
There was a problem hiding this comment.
Specify the type attribute for the button to avoid unintended form submissions. Recommended to set it to button.
<button
+ type="button"
onClick={() =>
open({
width: 600,
height: 800,
})
}
>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| <button | |
| onClick={() => | |
| open({ | |
| width: 480, | |
| height: 640, | |
| width: 600, | |
| height: 800, | |
| }) | |
| } | |
| > | |
| <button | |
| type="button" | |
| onClick={() => | |
| open({ | |
| width: 600, | |
| height: 800, | |
| }) | |
| } | |
| > |
Tools
Biome
[error] 31-38: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
No description provided.