Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors sendWebhook.js to not mandate Discord webhook URLs #347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Jonpot
Copy link
Contributor

@Jonpot Jonpot commented Feb 16, 2024

If a creature's webhook URL doesn't contain the standard Discord webhook URL format, it will simply push the data to the provided URL, instead of just failing to post anything.

If a creature's webhook URL doesn't contain the standard Discord webhook URL format, it will simply push the data to the provided URL, instead of just failing to post anything.
Copy link
Owner

@ThaumRystra ThaumRystra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests to confirm that the correct URL's are handled by the correct webhook sending mechanism

app/imports/server/discord/sendWebhook.js Outdated Show resolved Hide resolved
app/imports/server/discord/sendWebhook.js Outdated Show resolved Hide resolved
@Jonpot Jonpot requested a review from ThaumRystra November 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants