Iter23 #22
Merged
Iter23 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
The-Gleb
commented
Mar 17, 2024
The-Gleb
commented
- Add asymmetric encryption
- Add parsing config from json
- Graceful shutdown on SIGTERM,SIGQUIT,SIGINT
|
Не понимаю, как правильно установить поле restore в конфиге |
s-shpak
suggested changes
Mar 26, 2024
| return b | ||
| } | ||
|
|
||
| // TODO: it is unclear wether 'false' returned by -r flag is default or it was set by flag. |
There was a problem hiding this comment.
Существует несколько подходов к решению этой проблемы:
- Анмаршалить bool в
json.RawMessage(https://pkg.go.dev/encoding/json#RawMessage) и проверять его - использовать какую-то библиотеку типа
mergo, которая под капотом также анмаршалит сообщение в несколько проходов - перевернуть флаг (передавать
noRestoreвместоrestore)
Кажется, что первый вариант наиболее адекватен в данном случае
cmd/server/config.go
Outdated
|
|
||
| err = env.Parse(&builder.config) | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Не стоит вызывать Fatal из глубины кода: лучше прокинуть ошибку наверх и вызвать из main
golangci-lint/report.json
Outdated
|
|
||
| func NewDecryptionMiddleware(path string) *decryptionMiddleware { | ||
| if path == "" { | ||
| logger.Log.Info("path to private key is empty") |
There was a problem hiding this comment.
Если логировать это на уровне Info, то лог будет забиваться очень быстро. Наверное, стоит выбрать Debug
| http.Error(rw, err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
| // logger.Log.Debugf("request body is %s", string(cipher)) |
server
Outdated
s-shpak
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.