implement grpc controller and client #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Нужно ли добавить какие-то интерсепторы? |
s-shpak
suggested changes
Apr 7, 2024
cmd/agent/grpc_client.go
Outdated
|
|
||
| c := metrics.NewMetricServiceClient(conn) | ||
|
|
||
| // TODO: interceptors |
There was a problem hiding this comment.
Этот комментарий либо надо удалить, либо добавить интерсепторы, как планировалось
cmd/agent/grpc_client.go
Outdated
|
|
||
| } | ||
|
|
||
| // func (c *grpcClient) SomeInterceptor( |
cmd/agent/grpc_client.go
Outdated
|
|
||
| resp, err := c.client.UpdateMetricSet(context.Background(), in) | ||
| if err != nil { | ||
| log.Fatal(err) |
cmd/server/config.go
Outdated
|
|
||
| type Config struct { | ||
| Address string `json:"address" env:"ADDRESS"` | ||
| LogLevel string |
cmd/server/private.pem
Outdated
There was a problem hiding this comment.
Этот файл не стоит пушить в репозиторий, лучше добавь инструкции о том, как генерировать файлы с ключами
server
Outdated
There was a problem hiding this comment.
Не надо пушить бинарные файлы в репозиторий
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.