FOUNDATIONS: Assembly Service

[LBoullosa]

Closes: #5

[glhays]

@LBoullosa @cjdutoit LGTM
As to what Christo mentioned in Discord do we need a couple of test cases for exceptions like DirectoryNotFound and FileNotFound.

[LBoullosa]

@LBoullosa @cjdutoit LGTM As to what Christo mentioned in Discord do we need a couple of test cases for exceptions like DirectoryNotFound and FileNotFound.

@glhays FileNotFoundException is thrown by Assembly.Load, so yes, you are right we need to care about it.
DirectoryNotFound I don´t see it was thrown.

[glhays]

Is there a advantageous reason to convert the Assembly broker to asynchronous as to not block the constructor while the IO operations are being run?

[LBoullosa]

Is there a advantageous reason to convert the Assembly broker to asynchronous as to not block the constructor while the IO operations are being run?

There is no available methods for loading an assembly asynchronously.
Even no available method for GetFiles asynchronously.

If this is a problem, then we should remove the logic inside the ctor, because no support for asynchronous ctor. Then the logic should be splitted and wrapped inside a Task.Run.

Let´s see if we can improve this, I am agree, but could be done in a second version.
What do you think?