Skip to content

Commit

Permalink
ticketize TODOs with no corresponding issue
Browse files Browse the repository at this point in the history
- added #59
- added #60

- removed the TODO for "pull this clock index out into a score?" -- it will literally never matter
- removed the TODO for shootfacing -- we don't actually use any trig? (do we even use the `mathf` library??)
- removed the TODO for yarn 4. we're not going to do it, there's really no point as of now. yarn 3 is fine
  • Loading branch information
TheAfroOfDoom committed Jan 7, 2024
1 parent b200ee0 commit f4492d6
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 13 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ Since then I've gained a lot of skills both in Minecraft map development and in

#### Workspace

<!-- TODO upgrade to yarn 4? -->

1. Install [`Node.js >= 16.10`](https://nodejs.org/en/download)
2. Install [`Yarn 3.6.3`](https://v3.yarnpkg.com/getting-started/install) by running `corepack enable`
3. Initialize the repo by running `yarn`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ execute positioned ~ ~-1.5 ~ run function entity:utils/damage with storage utils
# Move forward
function entity:hostile/omega-flowey/attack/finger-guns/bullet/loop/move

# TODO: validate/determine a value for how long until the finger-guns bullets terminate
# TODO(60): validate/determine a value for how long until the finger-guns bullets terminate
# Terminate after X seconds
execute if score @s attack.clock.i matches 60.. run function entity:hostile/omega-flowey/attack/finger-guns/bullet/terminate
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Set scores
# TODO determine how to control how long we wait until ceding control back to the boss fight director
# TODO(49) determine how to control how long we wait until ceding control back to the boss fight director
# after an attack-executor stops looping
scoreboard players set @s boss-fight.attack.delay 20

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ execute if score @s attack.clock.i matches ..-1 run return 0
execute if score @s attack.clock.i matches 0 run function entity:hostile/omega-flowey/attack/finger-guns/indicator/loop/laser/presummon

# Summon a bullet
# TODO pull this clock index out into a score?
execute if score @s attack.clock.i matches 5 run function entity:hostile/omega-flowey/attack/finger-guns/indicator/loop/bullet/presummon

# Terminate after finger-gun shoot animation finishes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Set fake player scores back to defaults (if they were changed by a pre-initialize attack function)
# TODO: verify this indicator count
# TODO(60): validate these attack parameters
# (66 / 3) + 1 = 22 + 1 = 23 indicators
scoreboard players set #attack-finger-guns attack.executor.clock.length 66
scoreboard players set #attack-finger-guns attack.executor.rate 3
Expand Down
7 changes: 0 additions & 7 deletions scratch.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,3 @@ LCM = 572 ticks = 28.6s

datapack performance benchmarking?
https://github.com/SnaveSutit/mcworld-performance-dp/tree/test-tag-branch-selection-vs-macro-uuid-list-selection

TODO add post-git to recommendations in root README.md setup info
adds auto complete for git commands
https://github.com/dahlbyk/posh-git

TODO can probably replace most of the trig we use with shootfacing?
https://www.reddit.com/r/minecraftcommands/wiki/questions/shootfacing

0 comments on commit f4492d6

Please sign in to comment.