♻️ replace player-selectors with macro UUIDs/volume bounds #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- biggest change here is that only the active player + spectators will hear bossfight sounds and music
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
most of our player selectors (esp
@as weren't bounded by anything, so stuff like sounds were playing to every player in the world regardless of location).these are now bounded to their specific contexts (e.g. bossfight music/sounds only playing to the active player + spectators)
Supplemental changes
c7e3fff(#225): 🧑💻 storeactive_player_uuidto storage when running attack test suite6da497e(#225): 🚸 stop bossfight music/sounds when player leaves spectator box