🚸 🔊 normalize and tune volume of all sound files #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wont break people's ears now
- sounded very low quality in-game, we'll just use the volume property in sounds.json instead
…lly are - amplify them to keep LUFS close
- fix bounce sound source location bug
- apparently stereo sounds ARE increased by volume in the playsound command. great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tuning sound volume is a very manual process.
at the very least we added a script to track each sound file's LUFS value: https://en.wikipedia.org/wiki/LUFS
Reproducing
(powershell)