add js linting #51
Closed
add js linting #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAfroOfDoom
force-pushed
the
add-js-linting
branch
2 times, most recently
from
f854f36 to
dd4b2f1
Compare
- it was inconsistent for Aidan, this should be better?
use `.editorconfig` for settings
TheAfroOfDoom
force-pushed
the
add-js-linting
branch
from
dd4b2f1 to
6c1cbe2
Compare
- rename test workflow to `validate_datapack` - change test workflow to only run on commits on PRs and commits that are pushed to main
- run with `yarn lint`
TheAfroOfDoom
force-pushed
the
add-js-linting
branch
from
6c1cbe2 to
542c18d
Compare
- just ran `yarn start lint.fix`
- also run `yarn dlx @yarnpkg/sdks vscode` to make eslint work -- moves some auto generated settings into `.vscode/settings.json` - unavoidable but nbd - adds annoying extension to workspace recommendations `zipfs` but i guess useful similar to `node_modules` stuff idk
- no need to specify `--exact` - revert deleting the whole file earlier (woops)
TheAfroOfDoom
force-pushed
the
add-js-linting
branch
from
06476cb to
e765825
Compare
- convert to using `yarn` directly to run prettier too with dependency caching maybe
TheAfroOfDoom
force-pushed
the
add-js-linting
branch
from
e765825 to
8635f5a
Compare
- matches README's recommendation, which is based on minimum node version (`16.10`) needed for `corepack enable` / yarn 3.6.3
|
closing due to very messy force-push history reusing branch + workflow runs on next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Reproducing in-game
Preview
Supplemental changes