-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mvp for finger-guns
attack
#58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attack helper (`executor`/`indicator`/`bullet`) - don't love the term `helper` to refer to all of the above.. - `x-bullets-upper` had a useless initialization of `attack.clock.length` in its `indicator` -- probably happened during #30
what steps lmao
- e.g. "x position" -> "x-position"
- also don't copy `.md` files to Minecraft directory - we were getting errors in the game output on `/reload`s due to `README.md` in the convenience (e.g. `_:attack`) directory not being .mcfunction files (or .mcmeta, etc)
- also rename `consoleLog` -> `consoleLogScore`
- wasn't actually hitting grounded players
- no need to passthrough consts as params when we can just specify them in the code directly - makes it a little more immediately readable
- we already set `Rotation` in `laser/summon`
…cutor/indicator/presummon` - had to also adjust where we store x/y/z positions as a result
- looks better
- this makes it so we dont have to modify the rest of the animation just for the attack to have a correctly flipped model :) - also removes incorrect root animation frames
- move indicator inside arena z-bounds more for model to look better
- need duplicate `blank` / `moss_block` textures for this to work - changed default variant to shot to avoid duplicating `polished_granite` texture - add `variant=cocked` keyframe to `grow` animation to compensate for default variant changing - should require no changes to omega-flowey code
- also decrease length indicator exists to match length of `shoot` animation (despawn indicator sooner)
- added #59 - added #60 - removed the TODO for "pull this clock index out into a score?" -- it will literally never matter - removed the TODO for shootfacing -- we don't actually use any trig? (do we even use the `mathf` library??) - removed the TODO for yarn 4. we're not going to do it, there's really no point as of now. yarn 3 is fine
tested by manually adding it to the boss_fight.phase.0 weights
- it broke the watch script on directories that coincidentally had both `m` & `d` in their path. e.g. `datapacks/.../random/...`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
finger-guns
attack. It includes:finger-gun
,finger-gun-bullet
,finger-gun-blinking-line
)tbh this was pretty painful and slow to model but its finally done (or at least an MVP of it..). may revisit this? probably not, am "happy enough" with it for now
Reproducing in-game
Preview
models
finger-gun
--cocked
finger-gun
--shot
finger-gun-bullet
finger-gun-laser
animations
finger-gun
--grow
finger-gun
--shoot
finger-gun-bullet
-shoot
attack
videos with sound
Supplemental changes
consoleLogStorage
shorthand in vscode datapack-helper for console-logging storage values: 1d3141cmodifyyarn start
script to ignore.md
files: e3ef6d38efdb62
(#58)executor
/indicator
/bullet
)post-git
install steps/recommendations to README #59finger-guns
attack parameters #60