-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mvp for bomb
attack
#67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also convert indicator to marker entity
- was copying duplicate directory
see parent commit
- summons 6 bombs at randomized XZ locations, two bombs per tick
- falls slow at start, then falls fast and explodes when hits ground
- was running on directories too which led to errors
33f0efc
to
da687ff
Compare
- makes sure all our TODOs are formatted properly and have a ticket number - wanted to check to make sure it links to an real + open ticket, but we'd have to do some github api stuff which is too much lift for what its worth tbh
- `yarn start lint.custom.datapacks` - `yarn start lint.custom.other` - `yarn start lint.custom[.all]`
da687ff
to
4674472
Compare
4674472
to
67d1eb2
Compare
d1962e9
to
50288c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
bomb
attack. It includes:bomb
)Test plan
no unit tests :(
Reproducing in-game
Preview
model
unchanged model from #55
bomb
animations
bomb
--summon
bomb
--explode
attack
videos with sound
Supplemental changes
bomb
attack: validatebomb
attack parameters #68e1b3d7a
(#67)8d05ac5
(#67)67d1eb2
(#67)