Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mvp for bomb attack #67

Merged
merged 39 commits into from
Jan 14, 2024
Merged

add mvp for bomb attack #67

merged 39 commits into from
Jan 14, 2024

Conversation

TheAfroOfDoom
Copy link
Owner

@TheAfroOfDoom TheAfroOfDoom commented Jan 13, 2024

Summary

This PR adds the bomb attack. It includes:

  • attack functionality (commands)
  • the model for the attack (bomb)
  • sounds for the attack

Test plan

no unit tests :(

Reproducing in-game

function _:reset
function _:attack/bomb

Preview

model

unchanged model from #55

bomb
293608829-cc5fdbfc-788f-4e6c-baa0-e661fbd1839f

animations

bomb -- summon bomb -- explode
animation-summon animation-explode

attack

in-game -- before in-game -- after, player view
before after player-view
undertale in-game -- after, top-down view
undertale after top-down

videos with sound

in-game -- before in-game -- after undertale
https://youtu.be/2IprmKr31pU?t=353 https://youtu.be/-tyYMU4LsBw https://youtu.be/8jmptY4uCkk?t=97

Supplemental changes

- also convert indicator to marker entity
- was copying duplicate directory
see parent commit
- summons 6 bombs at randomized XZ locations, two bombs per tick
- falls slow at start, then falls fast and explodes when hits ground
- was running on directories too which led to errors
- makes sure all our TODOs are formatted properly and have a ticket number
- wanted to check to make sure it links to an real + open ticket, but we'd have to do some github api stuff which is too much lift for what its worth tbh
- `yarn start lint.custom.datapacks`
- `yarn start lint.custom.other`
- `yarn start lint.custom[.all]`
@TheAfroOfDoom TheAfroOfDoom merged commit 255b71d into main Jan 14, 2024
5 checks passed
@TheAfroOfDoom TheAfroOfDoom deleted the attack-bomb branch January 14, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant