fix .gitattributes not hiding diffs for Animated Java export files on old PRs
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#71 attempted to add all the AJ export files to
.gitattributesaslinguist-generatedso old PR file diffs would be more useful to look at (and actually render important, non-AJ-export files)We got the syntax wrong though and forgot to add
/**for directories. This PR fixes that.It also fixes the
datapacks/mathfmissing the same syntax so GitHub excludes thatmathfdatapack library from repo stats.Lastly we also make
.ajmodels render with JSON highlighting.Test plan
tested by manually uploading files to old AJ export paths and making sure GitHub didn't render their diffs (see
Previewsection below)Reproducing in-game
N/A
Preview
.ajmodelbefore.ajmodelafterSupplemental changes
N/A