Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: Project Euler Problem 19 #1174

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MatheusMuriel
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add some comments.

@MatheusMuriel
Copy link
Contributor Author

Added the comments and refactored to make more legible

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning the terse leap year condition into an if-else construction that takes about twenty times as much vertical space (!) is pretty bad. If anything, the current construction should be made to use a ternary rather than relying on coercion from bool to 0 or 1.

The rename of n to numberOfSundays does indeed improve readability though.

Copy link
Contributor Author

@MatheusMuriel MatheusMuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a ternary if

@MatheusMuriel
Copy link
Contributor Author

offtopic: @appgurueu i saw that you like Lua, a professor at my university studied in the department that developed the Lua language at PUC-Rio 😄

appgurueu
appgurueu previously approved these changes Oct 24, 2022
@raklaptudirm raklaptudirm changed the title Included Project Euler 19 solution solution: Project Euler Problem 19 Oct 25, 2022
raklaptudirm
raklaptudirm previously approved these changes Oct 25, 2022
@appgurueu
Copy link
Collaborator

offtopic: @appgurueu i saw that you like Lua, a professor at my university studied in the department that developed the Lua language at PUC-Rio smile

Oh that's nice!

@appgurueu appgurueu dismissed stale reviews from raklaptudirm and themself via b5cfb1e October 25, 2022 09:27
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants