Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Project Euler 22 #1224

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MatheusMuriel
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to move the names to a separate file (rather than embedding them in the code)?

@MatheusMuriel
Copy link
Contributor Author

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

@appgurueu
Copy link
Collaborator

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

Test folder sounds fine to me (next to the test file).

@MatheusMuriel
Copy link
Contributor Author

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

Test folder sounds fine to me (next to the test file).

Ok, I will do it

@@ -1,3 +1,5 @@
import * as fs from 'fs'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just import readFileSync from fs? It seems to be the only function you need.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants