Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add Bogo Sort #79

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Feat: add Bogo Sort #79

merged 4 commits into from
Nov 12, 2024

Conversation

ibrahimelnemr
Copy link
Contributor

Add file bogo_sort.nim within a new sorts directory, includes tests and runnableExamples

@ibrahimelnemr ibrahimelnemr requested a review from dlesnoff as a code owner August 3, 2024 08:26
dlesnoff
dlesnoff previously approved these changes Nov 11, 2024
@dlesnoff
Copy link
Collaborator

dlesnoff commented Nov 11, 2024

Please run nimpretty on your file. Otherwise, the tests and the code are fine to me.

@ibrahimelnemr
Copy link
Contributor Author

Please run nimpretty on your file. Otherwise, the tests and the code are fine to me.

Sure, I ran it and committed it to this PR

@dlesnoff
Copy link
Collaborator

Does your editor remove the newline at the end of the file? My nimpretty (version 0.2, the one shipped with Nim 2.2.0 by choosenim) adds a newline at the end.

@ibrahimelnemr
Copy link
Contributor Author

Does your editor remove the newline at the end of the file? My nimpretty (version 0.2, the one shipped with Nim 2.2.0 by choosenim) adds a newline at the end.

No, my bad I took out the newline. I ran nimpretty again and it should have the newline now

@dlesnoff dlesnoff merged commit 9083bb9 into TheAlgorithms:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants