-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A queue implementation using a singly linked list #813
Conversation
Fixed incrementing length in the insert method of the Queue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 95.31% 95.28% -0.03%
==========================================
Files 310 311 +1
Lines 22430 22717 +287
==========================================
+ Hits 21380 21647 +267
- Misses 1050 1070 +20 ☔ View full report in Codecov by Sentry. |
Please read the CONTRIBUTING guidelines before submitting the PR. Ensure all the checks passed (currently the fmt and clippy failed). And the most important thing is that, please add tests that cover 100% of the code. |
Pull Request Template
Description
A queue implementation using a singly linked list, Its fast and efficient because it leverages efficiency of a linked list
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.