Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A queue implementation using a singly linked list #813

Closed
wants to merge 16 commits into from
Closed

A queue implementation using a singly linked list #813

wants to merge 16 commits into from

Conversation

Ismael144
Copy link

@Ismael144 Ismael144 commented Oct 10, 2024

Pull Request Template

Description

A queue implementation using a singly linked list, Its fast and efficient because it leverages efficiency of a linked list

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran below commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 93.03136% with 20 lines in your changes missing coverage. Please review.

Project coverage is 95.28%. Comparing base (209c1b4) to head (b3286ef).

Files with missing lines Patch % Lines
.../data_structures/queue_using_singly_linked_list.rs 93.03% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   95.31%   95.28%   -0.03%     
==========================================
  Files         310      311       +1     
  Lines       22430    22717     +287     
==========================================
+ Hits        21380    21647     +267     
- Misses       1050     1070      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozelfist
Copy link
Contributor

Please read the CONTRIBUTING guidelines before submitting the PR. Ensure all the checks passed (currently the fmt and clippy failed). And the most important thing is that, please add tests that cover 100% of the code.

@Ismael144 Ismael144 closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants