Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress too_long_first_doc_paragraph #838

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Nov 2, 2024

Pull Request Template

Description

This PR is a reaction to new clippy warnings: some failing log, cf. #837.

Type of change

Please delete options that are not relevant.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from siriak November 2, 2024 18:17
@vil02 vil02 marked this pull request as ready for review November 2, 2024 18:18
@vil02 vil02 requested a review from imp2002 as a code owner November 2, 2024 18:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (5a83939) to head (7406462).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files         315      315           
  Lines       22809    22809           
=======================================
  Hits        21768    21768           
  Misses       1041     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit 857c73a into TheAlgorithms:master Nov 2, 2024
4 checks passed
@vil02 vil02 mentioned this pull request Nov 2, 2024
10 tasks
@vil02 vil02 mentioned this pull request Dec 5, 2024
10 tasks
@vil02 vil02 deleted the ignore_too_long_first_doc_paragraph branch January 12, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants