-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the implementation of the Edmond Karp algorithm along with test cases #252
Added the implementation of the Edmond Karp algorithm along with test cases #252
Conversation
maths/bisection_method.ts
Outdated
@@ -0,0 +1,27 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get rid of these unrelated changes in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this isn't resolved. The changes are still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still there. Maybe you forgot to push a commit that gets rid of these additions (bisection_method.ts
, decimal_convert.ts
, euler_method.ts
)?
I am extremely sorry for all the mistakes I have done and submitted the code for a review with twice checking it my self |
Co-authored-by: Lars Müller <[email protected]>
Co-authored-by: Lars Müller <[email protected]>
I have tried implementing the changes suggest by @appgurueu |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 96.82% 96.89% +0.06%
==========================================
Files 98 100 +2
Lines 1829 1867 +38
Branches 345 354 +9
==========================================
+ Hits 1771 1809 +38
Misses 58 58 ☔ View full report in Codecov by Sentry. |
Updated the test cases
Updated the code and rewrite some functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implement the changes suggest by you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be asymptotically fine now. Looks correct.
Added the implementation of the Edmond Karp algorithm along with test cases