Fix platform-specific preprocessor directive for Linux #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `_LINUX` with `__linux__` to align with standard platform
macros.
This ensures proper compilation and debugging functionality on Linux
systems.
No other logic or functionality was affected.
Signed-off-by: Victor Matia <[email protected]>
OmniBlade
approved these changes
Mar 13, 2025
Replaced multiple Linux compiler checks with a unified `_LINUX` define. This improves consistency and reduces redundancy in platform-specific code handling. This also ensures the code compiles in more distributions and versions of Linux systems. Signed-off-by: Victor Matia <[email protected]>
|
I added better standardization for the Linux macro defines as discussed privately to support all expected macros under the previously used macro. |
Fixed the way the macro `_LINUX` is checked for to prevent UB in some compilers. Signed-off-by: Victor Matia <[email protected]>
OmniBlade
approved these changes
Mar 13, 2025
Updated the Linux platform detection logic to include the 'linux' macro, ensuring broader compatibility. Referenced cpredef documentation for clarity and standardized coverage. Signed-off-by: Victor Matia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
_LINUXwith__linux__to align with standard platform macros.This ensures proper compilation and debugging functionality on Linux systems.
No other logic or functionality was affected.