Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format-security error #1026

Merged

Conversation

xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Jan 3, 2025

In macOS clang version 19.1.5

/Vanilla-Conquer/tiberiandawn/netdlg.cpp:4079:27: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
 4079 |             sprintf(buf1, Text_String(TXT_WAITING_FOR_CONNECTIONS));
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Vanilla-Conquer/tiberiandawn/netdlg.cpp:4079:27: note: treat the string as an argument to avoid this
 4079 |             sprintf(buf1, Text_String(TXT_WAITING_FOR_CONNECTIONS));
      |                           ^
      |                           "%s", 

@OmniBlade OmniBlade merged commit fa78f6d into TheAssemblyArmada:vanilla Jan 31, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants