Limited number of tile requests #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eading tile data. Avoided duplicate requests. Fixed fetch tile func to check for bad requests. Update constraints for iPad storyboard.
jterhorst
suggested changes
Jan 14, 2020
| @@ -46,6 +46,6 @@ | |||
| - (nullable id)initWithFrame:(MKMapRect)frame x:(NSInteger)x y:(NSInteger)y z:(NSInteger)z; | |||
| - (nullable id)initWithFrame:(MKMapRect)frame configuringURLSession: (NSURLSessionConfiguration* _Nonnull)configuration x:(NSInteger)x y:(NSInteger)y z:(NSInteger)z; | |||
|
|
|||
| - (void)fetchTileForFrameIndex:(NSInteger)frameIndex session:(NSURLSession *)session completionHandler:(void (^)(NSData * date, NSURLResponse * response, NSError * error))completionBlock; | |||
There was a problem hiding this comment.
Why are we removing the response object from this block?
| } | ||
| if (tileData) { | ||
| //The setNeedsDisplayInMapRect is called once for each downloaded sub-tile of the mapRect (4-6 sub-tiles for retina). | ||
| [weakSelf setNeedsDisplayInMapRect:mapRect zoomScale:zoomScale]; |
There was a problem hiding this comment.
Does setNeedsDisplayInMapRect:zoomScale: restart the requests for tiles?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a set to keep current downloading tiles.
Synchronized loading/reading tile data.
Avoided duplicate requests.
Fixed fetch tile func to check for bad requests.
Update constraints for the iPad storyboard.
Via Charles proxy app, I can see that number of requests was reduced from 2000 to 144 for one zone level = 4.
The Mapbox had a similar problem back in 2015 mapbox/mbxmapkit#167