Support LLVM 17 #460
Merged
Support LLVM 17 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the following LLVM-C API changes:
* Core
* Removed functions:
* LLVMContextSetOpaquePointers
* LLVMConstSelect
* Transforms
* PassRegistry and pass initialization removed, as they were
the part of legacy Pass Manager. This results in complete
removal of the following modules:
* instcombine
* ipo
* pass_manager_builder
* scalar
* util
* vectorize
* Debug info
* New language:
* Mojo
Fixes: #444
Signed-off-by: Alex Saveau <[email protected]>
|
@TheDan64 got it working! |
TheDan64
reviewed
Jan 11, 2024
src/values/mod.rs
Outdated
| @@ -47,7 +47,7 @@ pub use crate::values::traits::AsValueRef; | |||
| pub use crate::values::traits::{AggregateValue, AnyValue, BasicValue, FloatMathValue, IntMathValue, PointerMathValue}; | |||
| pub use crate::values::vec_value::VectorValue; | |||
|
|
|||
| #[llvm_versions(12.0..=latest)] | |||
| #[llvm_versions(12.0..=16.0)] | |||
| use llvm_sys::core::LLVMIsPoison; | |||
There was a problem hiding this comment.
Is poison no longer supported in LLVM17?
There was a problem hiding this comment.
Looks like it still is, so I'll revert that later tonight: https://docs.rs/llvm-sys/latest/llvm_sys/?search=LLVMIsPoison
There was a problem hiding this comment.
Actually that import wasn't even being used so I got rid of it.
Signed-off-by: Alex Saveau <[email protected]>
TheDan64
approved these changes
Jan 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from and closes #448, fixes #444.