-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide get_gep_source_element_type and InstructionValue -> CallSiteValue #506
Conversation
@vaivaswatha there are some test failures that need to be addressed |
This reverts commit baaa982.
@TheDan64 I've fixed the build failures for other versions of LLVM. But there're still tests failing with segfaults that aren't related to my change. I'm not sure what's happening. |
btw, I've also added an Would it be a good idea to also provide these methods ( |
Hi @vaivaswatha, there are still some test failures that need to be addressed. It doesn't seem to compile even after the master branch changes have been fixed.
If the method applies to all variants of the trait, without exception, I'd rather see it added to the |
This PR adds two new functionality:
get_gep_soruce_element_type
: Takes as input a GEP instruction and returns the source element type.InstructionValue
toCallSite
.Related Issue
If the changes are acceptable (i.e., in the right direction), I'll create one and edit this description.
How This Has Been Tested
I've tested the change against LLVM-17, as "cargo test -F llvm17-0"