Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved documentation for build_int_mul, build_int_sub, build_float_sub and build_float_mul #535

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

OranGot
Copy link

@OranGot OranGot commented Sep 16, 2024

Description

Improved documentations for functions in the title in builder.rs file with examples.

How This Has Been Tested

I have not tested these changes since it's just a slight documentation change and I edited no code

Checklist

  • [y ] I have read the Contributing Guide
    ##Warning
    This is my first ever pull request so it may not be the best.

Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks pretty good, just needs some minor cleanup

src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
@TheDan64 TheDan64 added this to the 0.6.0 milestone Sep 19, 2024
@TheDan64
Copy link
Owner

@OranGot your PR will need some fixes before it can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants