feat: merge server error handling functions into handleServerError
#257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in this PR merges the functionality of
handleServerErrorLog
andhandleReturnedServerError
functions into a single optional initialization function calledhandleServerError
. This change has been made because having two functions for server error handling is unnecessary, you can easily manage both logging and returned error within a single function.Upgrade guide
Suppose you have this code using next-safe-action < 7.9.0:
With next-safe-action >= 7.9.0 it becomes:
So, minimal refactoring is required, and the action client creation is cleaner this way.
Note
Even if you want to change just the logging mechanism, you still have to return an error shape from
handleServerError
, otherwise the resulting type would bevoid
.So, if you want for instance keep the default error message as the returned server error and just update the console logging, you can do it like this: