feat: add support to custom base URL and models #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelbig1
approved these changes
Oct 23, 2024
|
you will need to update this to work with genkit 0.9.1 |
xavidop
requested changes
Nov 19, 2024
| @@ -106,7 +112,8 @@ export const openAI: Plugin<[PluginOptions] | []> = genkitPlugin( | |||
| throw new Error( | |||
| 'please pass in the API key or set the OPENAI_API_KEY environment variable' | |||
| ); | |||
| const client = new OpenAI({ apiKey }); | |||
| const baseURL = options?.baseURL || process.env.OPENAI_BASE_URL; | |||
There was a problem hiding this comment.
we should set one by default if both are empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to:
I have checked the following:
Description:
This Pull Request adds support for custom Base URL and custom models for the OpenAI client. With tools like LiteLLM, and LLM providers like OpenRouter that offers a great variety of models under the OpenAI API Specification, we support private and custom LLMs with the same plugin.
Related issues:
Please, link the related issues that this pull request will resolve here (if any).
This Resolves #56