Added cannon operation counter #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and thanks for this PR ! Nice piece to code, this could be really helpful to have per turret information in addition of global summary at the end of tests. Plus, I see that you've added logic to stop cannons after N operations, which could be a very useful feature in some cases |
|
And how do you think I should get up the count data ? |
|
This could be tricky with this turret because of threads. I think the easy way is to use a Queue and merge results after cannons join |
ZuluPro
changed the title
|
Updated ! |
|
@karec Do yo think e can merge this PR ? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about this piece of code ?
I would like to get a summary of operations' status:
This code helps to produce a result by cannon and may help to have one by turret.