Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Speed up admin learner search #4918

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

KevinMulhern
Copy link
Member

Because:

  • The default configuration is not fast enough for the amount of data we have in production.

This commit:

  • Adds a ts_vector column to the users table which we can search against - this is recommended in the pg_search docs
  • Sneaks in a data-turbo-action="advance" attribute to the learner search results turbo frame so we can share search result pages with admins if we need to.

@KevinMulhern KevinMulhern force-pushed the chore/speed-up-learner-search branch from 5ac3f97 to c2f035c Compare February 12, 2025 15:23
Because:
- The default configuration is not fast enough for the amount of data we have in production.

This commit:
- Adds a ts_vector column to the users table which we can search against - this is recommended in the [pg_search docs](https://github.com/Casecommons/pg_search?tab=readme-ov-file#using-tsvector-columns)
- Sneaks in a data-turbo-action="advance" attribute to the learner search results turbo frame so we can share search result pages with admins if we need to.
@KevinMulhern KevinMulhern force-pushed the chore/speed-up-learner-search branch from c2f035c to fb2e477 Compare February 12, 2025 15:25
@KevinMulhern KevinMulhern merged commit 403dc98 into main Feb 12, 2025
5 checks passed
@KevinMulhern KevinMulhern deleted the chore/speed-up-learner-search branch February 12, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant