Feature: Provide loading feedback when completing a lesson on a slow connection #4942
+36
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
force-pushed
the
feature/complete-button-loading-feedback
branch
from
314bff6 to
02b84a3
Compare
…connection Because: - The complete button will appear to "hang" on slower connections. This commit: - Adds loading spinners to the complete button on lesson and course pages, that will only appear when toggling complete and the connection is slow. - Bumps turbo-rails to latest patch version so we can use the :morph option when replacing content with turbo streams and avoid hover flashes on buttons as the content is replaced. - Switch the complete button on course pages from links to buttons as they are not making GET requests. - Removes some old Stimulus JS hooks for a complete controller that has been removed long ago.
KevinMulhern
force-pushed
the
feature/complete-button-loading-feedback
branch
from
02b84a3 to
7719e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Lesson page loading spinner:
Screen.Recording.2025-02-21.at.16.09.29.mov
Course page loading spinner:
Screen.Recording.2025-02-21.at.16.08.59.mov