Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new device and change pictures for device #639

Merged
merged 15 commits into from
Dec 4, 2023
Merged

add new device and change pictures for device #639

merged 15 commits into from
Dec 4, 2023

Conversation

yosensi
Copy link
Contributor

@yosensi yosensi commented Jul 4, 2023 •
edited
Loading

Summary

chnaged pictures of the devices, add people counter

Changes

  • description YO Pulse and YO modbbus, sensors in YO modbus & YO analog (yaml files)
  • added new people counter device

Notes for Reviewers

...

Release Notes

  • ...

yosensi and others added 4 commits May 18, 2023 14:20
@yosensi yosensi requested a review from Jaime-Trinidad as a code owner July 4, 2023 10:57
yosensi and others added 4 commits July 4, 2023 13:02
@yosensi
prettier changes
4dcbc61 
Change-Id: Icd5c534283a0356893286d9662a2d077567b6887
@yosensi
prettier changes2
e896f0b 
Change-Id: I024db2f704f9786d5c887635d4201fed5a4b40c4
@yosensi
Update index.yaml
98db3f4
@yosensi
Update index.yaml
808d8b4
yosensi
yosensi commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@yosensi yosensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added new photo for devices, changed index, added yo people counter

yosensi
yosensi commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@yosensi yosensi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted email in index.yaml

@Jaime-Trinidad
Copy link
Contributor

@yosensi please rum make validate fmt

@yosensi
Copy link
Contributor Author

yosensi commented Jul 19, 2023

@Jaime-Trinidad I did validation format and every file in Visual studio for Yosensi vendor is valid. Idk why here when it trys to do it again (I mean run prettier function) it fails. Can you suggest something what I can do in this situation?

yosensi
yosensi commented Jul 19, 2023
View reviewed changes
Copy link
Contributor Author

@yosensi yosensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted empty lines in modbus.yaml

yosensi added 2 commits August 8, 2023 10:44
@yosensi
fix .json conflicts
54d0d15 
Change-Id: I02cba75e5e0216d581a6560e5c7b8d50ac000726
@yosensi
Merge remote-tracking branch 'ttn/master'
92b3eac 
Change-Id: I2952791cb77e1694bad98ffcace2e76378dabb54
@yosensi
Copy link
Contributor Author

yosensi commented Aug 16, 2023

Hello I reslove

@yosensi yosensi closed this Aug 16, 2023
@yosensi yosensi reopened this Aug 16, 2023
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yosensi yosensi marked this pull request as draft November 2, 2023 10:24
yosensi
yosensi commented Nov 2, 2023
View reviewed changes
Copy link
Contributor Author

@yosensi yosensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes aproved

@yosensi yosensi marked this pull request as ready for review November 2, 2023 10:25
@Jaime-Trinidad Jaime-Trinidad merged commit 39fb5ba into TheThingsNetwork:master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaime-Trinidad Jaime-Trinidad Jaime-Trinidad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yosensi @Jaime-Trinidad @CLAassistant @tomasz-grabowski-netbulls