-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag dropdowns #690
Add tag dropdowns #690
Conversation
Device.Repo.Homepage.Proposal.movhere is a proposal for an uplifting of the Device Repository home page cc @KrishnaIyer |
This looks really fantastic. @wienke @kschiffer please review the new design. @mjamescompton: Can you please comment on the SEO implications? |
@pierrephz: Where does the |
These filter need to work for everything page type not just the homepage. For now I think we are good having a page that contains every single device in the repo but at some point this page will become very slow. This may in happen when we start to parse the json and render everything when we are not using our Shinny new M1's. At this point it might time to add a more curated homepage #188 and then spilt the devices up in to categories. Our second most valuable page other then the homepage is https://www.thethingsnetwork.org/device-repository/tags/temperature/ (we can still get this page a little higher if we complete this task #185 @KrishnaIyer ) This tag page will also need these filters as there are already to many devices on this page. For this work the filter need to populated based on the content on the page and the page need to contain all devices already in the html. I think the best way to do this is With a JSON object containing all the device data on a page (homepage, tag, or device maker) on the page. We would still have all the devices on the page in html when it loads, this json object will also be there ready for js to consume. When the filter dropdown is press we could rebuild the devices list from this json The json object will be generated by hugo, I believe as we are already requesting the tag we will already have an object with the devices from that tag and it might even already have the attributes. We are already generating something similar to this json object on the single device page
We need to write the custom js to filter the elements. |
Summary
Add a dropdown menu that lists certain types of tags to filter through the devices.
Changes
Note
This is basically the same PR as #680 but i accidentally deleted the fork. Whoops. Please refer to that PR for the discussions around it.