Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/au915 fsb1 dwelltime off #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EduardoPfeifer
Copy link

Summary

References #55

Changes

  • Added AU915-928 FSB 1 variant with dwell time disabled (uplink and downlink)

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • Testing: The changes are tested.
  • Documentation: Relevant documentation is added or updated.

@johanstokking
Copy link
Member

In which case can this be used in Austrlia?

@EduardoPfeifer
Copy link
Author

In which case can this be used in Austrlia?

The idea is to use in Brazil, not necessary Australia. Since the region em regulamentation don't restrict the dwell time of uplinks.

References:
Frequency Plans by Country
National Telecommunications Agency (ANATEL) Resolution No. 680, from June 27, 2017 - Portuguese only, Article 10
National Telecommunications Agency (ANATEL) Act No. 14448, from December 4, 2017 - Portuguese only Section 10.3

frequency-plans.yml Outdated Show resolved Hide resolved
frequency-plans.yml Outdated Show resolved Hide resolved
@adriansmares
Copy link
Contributor

adriansmares commented Oct 28, 2022

I am inclined to propose that we also introduce the NDT variants of the other FSBs, and that instead of cloning the plan, we disable dwell time via inheritance:

- id: AS_923_2_NDT
band-id: AS_923_2
name: Asia 920-923 MHz (AS923 Group 2) with only default channels and dwell time disabled
description: Compatibility frequency plan for Asian countries with common channels in the 921.4-922.0 MHz sub-band and dwell time disabled
base-frequency: 915
base-id: AS_923_2
file: disable_dwell_time.yml

In this case you just inherit the original plan (using base-id) and then extend it with disable_dwell_time.yml.

@johanstokking
Copy link
Member

I am inclined to propose that we also introduce the NDT variants of the other FSBs

We'll get a lot of plans then, right?

I'm almost inclined to take a step back and see if we should split channel plans (frequencies) from regulations (max EIRP, dwell time, duty cycle). I believe we're mentally preparing for a refactoring of the frequency plan handling anyway.


I agree to use https://github.com/TheThingsNetwork/lorawan-frequency-plans/blob/master/disable_dwell_time.yml anyhow, regardless of how many FSBs we support. @EduardoPfeifer does BR allow all AU915 defined channels?

@adriansmares
Copy link
Contributor

adriansmares commented Oct 28, 2022

We'll get a lot of plans then, right?

We already have 14 AS_923 variants, but using inheritance they are very easy to maintain in that regard.

My plan for #38 is to mark the base plans (for which the dwell time is 'unknown'/'default') as deprecated, such that the UI stops them from rendering in the plans list unless you had it pre-selected. Then you would only see 16 plans (8 with DT and 8 without DT).

Also by marking the _TTN or at least Used by TTN variants as endorsed (#51), we can make selection easier - you only see the endorsed plans, and a button to load the rest if none of them are applicable. Then you would see only two plans at most (and if we make the endorsement depend on the country, even only 1).

I will re-write the refactoring issue with the ideas that we've been circulating for a while (separating end device from gateway plans, adding LR-FHSS support, endorsement and depreciation), but I don't think that adding these plans is bad necessarily. They can be there - it's just that we need to filter out more on what do we show / not show to the user when he has to make a choice.

@EduardoPfeifer
Copy link
Author

@EduardoPfeifer does BR allow all AU915 defined channels?

Yes, starting form 915 MHz to 928 MHz. The most common sub-band (approximately 90%) is the FSB 1 (915.2 MHz .. 916.6 MHz).

Comment on lines +162 to +168
- id: AU_915_928_FSB_1_NDT
band-id: AU_915_928
name: Australia 915-928 MHz, FSB 1
description: Frequency plan for Brazil (Australia base), using sub-band 1 and dwell time disabled
base-frequency: 915
country-codes: [br]
file: AU_915_928_FSB_1_NDT.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests based on the previous discussion:

  • add plans for the other FSBs
  • differentiate the name from the others (now they have the same name). Probably just append for Brazil or something
  • use the override mentioned by @adriansmares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants