-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ios track fullscreen controls #1669
Feature/ios track fullscreen controls #1669
Conversation
@CHaNGeTe this is very similar to fixes I have been making; although I added an additional bit of code to handle situations with fullscreen rotation. Let me know if you want to merge your PR, and I can keep my additional code for the future. |
Sorry Ash! Didn't remember you were working on this. Depending on the ETA of your PR we can release this as quick fix. Or wait for your PR itself. What do you think? |
hi @CHaNGeTe, would you mind if I update this PR with additional changes? |
feel free! |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "react-native-video", | |||
"version": "4.4.3", | |||
"version": "4.4.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 4.4.5 I guess?
Is this PR add a props to remove fullscreen button on iOS ? |
@jonathangreco it is not. It's code for optional callbacks when entering or exiting fullscreen |
merge this |
this fixed problem for me with #1319 had to use onFullscreenPlayerWillPresent = () => {
Orientation.unlockAllOrientations();
};
onFullscreenPlayerWillDismiss = () => {
Orientation.lockToPortrait();
}; thanks! |
@cobarx @jenshandersson @ashnfb @n1ru4l any notion when this could be merged? 🙏🏼 |
This works well in iOS12.4, iPhone6. However, In iOS 13.6, iPhone 11, this freezes the video when making it fullscreen. When trying to close fullscreen it crashes. This line is the culprit: |
putting it in |
I sent a PR to this branch that wants to PR here :D 24i#15 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue. |
Tracks fullscreen state when changed via controls, and call callbacks if needed