-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add listeners for full screen iOS #2379
add listeners for full screen iOS #2379
Conversation
i cant use them :( please fix them all |
@guy-catapultsports would you mind testing this PR for the iOS conversion to swift? It does not have the changes you have made here, but I'd be happy to add them in afterwards. I'm looking to have anyone who has contributed to ios test out the converted version. Please be aware that there is a required update to add |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue. |
When going fullscreen all callbacks are called. Only the present callbacks should have been called. |
@markholland what is your comment about? the PR changes or the current state of the code before the PR? |
This PR |
Will this be merged in the next version? |
@coneforapine not until the issues reported by @markholland are resolved. |
Since this PR is both stale and no one has offered any help in 2 months I am going to close it. If someone wants to port this to swift and submit a new PR, that would be greatly appreciated. |
It works for me, now all callbacks are calling fine.
Edit: sometimes present and dismiss callbacks are called at same time. it doesn't work well |
I have same issue. I downgraded to |
reference PR https://github.com/react-native-video/react-native-video/pull/1669/files
also might help with this issue: #552
This attempts to apply the same fix, specifically when the native controls are active on IOS.
Provide an example of how to test the change
Add these props to the Video component
Describe the changes
Added listeners for: