Add HeaderComponent #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoBrigitte
requested changes
Jan 24, 2025
Comment on lines
+3
to
+6
|
|
||
| import Status from "../statusComponent/StatusComponent"; | ||
|
|
||
| import { StatusProps } from "../statusComponent/type"; |
There was a problem hiding this comment.
Suggested change
| import Status from "../statusComponent/StatusComponent"; | |
| import { StatusProps } from "../statusComponent/type"; | |
| import Status from "../statusComponent/StatusComponent"; | |
| import { StatusProps } from "../statusComponent/type"; |
| @@ -2,12 +2,11 @@ | |||
|
|
|||
| import { useState } from "react"; | |||
| import useWebSocket from "react-use-websocket"; | |||
|
|
|||
Comment on lines
-45
to
-48
| <div className="flex flex-row justify-center"> | ||
| <div className="pt-10 pb-20 px-10"> | ||
| <div className="flex flex-row min-w-fit justify-center flex-nowrap text-nowrap"> | ||
| <div className="basis-1/4 flex flex-col justify-center items-center"> |
There was a problem hiding this comment.
I think there's some magic in there which broke the page center alignment when being removed.
tschanomis
force-pushed
the
headerComponent
branch
from
b7890de to
d66ca15
Compare
tschanomis
force-pushed
the
headerComponent
branch
from
d66ca15 to
9d14042
Compare
| server: Server; | ||
| } | ||
|
|
||
| // Define the color and icon the status column |
There was a problem hiding this comment.
Suggested change
| // Define the color and icon the status column | |
| // Define color and icon of the status column |
|
|
||
| useEffect(() => { | ||
| if (!dataEquality) { | ||
| console.log("change detected"); |
There was a problem hiding this comment.
Suggested change
| console.log("change detected"); |
|
|
||
| return ( | ||
| servers.map((server) => ( | ||
| <tr ref={React.createRef()} key={category + server.planCode} className={`${changedRows.has(server.planCode) ? 'bg-yellow-200' : 'transition duration-1000 delay-150 even:bg-blue-300 odd:bg-blue-100'} font-mono`}> |
There was a problem hiding this comment.
Please keep the odd/even colors.
| lastMessage, | ||
| }: StatusProps) { | ||
| return ( | ||
| <div className="HeaderComponent flex justify-evenly w-full"> |
There was a problem hiding this comment.
What is this HeaderComponent class used for ?
| const ordered: CategoryOrder = { ...categoryOrder, ...serversByCategory }; | ||
|
|
||
| return ( | ||
| <table className="text-nowrap border-separate border-spacing-x-0 border-spacing-y-4"> |
There was a problem hiding this comment.
No need for vertical spacing, this table is already quite big.
| <td>{server.storage}</td> | ||
| <td>{server.bandwidth}</td> | ||
| <td>{`${server.price} ${server.currencyCode}`}</td> | ||
| <td className="flex justify-end py-6"> |
There was a problem hiding this comment.
Why is this py-6 here instead of the tr ? This should also be reduced to reduce vertical space used.
| const serversByCategory = Object.groupBy(data, (server: Server) => server.category); | ||
|
|
||
| // Merge the server and respect the categories order | ||
| const ordered: CategoryOrder = { ...categoryOrder, ...serversByCategory }; |
There was a problem hiding this comment.
It would be nice to filter out categories with no servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the page header into a new HeaderComponent.