-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: codecov #1138
Closed
Closed
test: codecov #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to check before running a module/project template close issue #836
- fix 1004 adding bare skeleton function body - function name taken from 'name' arg to add_fct
Add -it flag when run docker so ^C still works
- check if README.Rmd exists; throw error if arg overwrite = FALSE, but overwrite if TRUE - uses a template from a function that returns an appropriate character - sets devtools::check chunk with option error=TRUE at the moment to ease testing this feature Possible To-Dos: - use smarter template e.g. from specific template-file.Rmd a-la usethis+whisker - add use_readme_md() that adds the correspodining .md file
- add more precise description for each argument in fill_desc() - change some capital letters to lower case in fill_desc() comments
- fix missing tests for make_action_button - possible bugfix for make_action_button - check with grepl instead of grep to avoid numeric(0) in if-statement which would make the corresponding test fail for button_6: class attribute present but not equal to "action-button" gives an error
build_readme causes an error if run non-interactively hence the skip_if_not(interactive()) is added in the first place after deleting build_readme() the test passes non-interactively though
- to clearly show what the testing coverage is on each branch via the badge - `README.Rmd` is altered to programatically retrieve the current git branch which automatically uses the correct coverage results from https://about.codecov.io/ Refs: #1086
- when CI rebuilds README.Rmd it should also use the badge of the git-branch so the codecov gets an update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.