Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: codecov #1138

Closed
wants to merge 156 commits into from
Closed

test: codecov #1138

wants to merge 156 commits into from

Conversation

ColinFay
Copy link
Member

No description provided.

ColinFay and others added 30 commits March 10, 2023 14:02
This can be used to check
before running a module/project template

close issue #836
- fix 1004 adding bare skeleton function body
- function name taken from 'name' arg to add_fct
Add -it flag when run docker so ^C still works
- check if README.Rmd exists; throw error if arg overwrite = FALSE, but overwrite if TRUE
- uses a template from a function that returns an appropriate character
- sets devtools::check chunk with option error=TRUE at the moment to ease testing this feature

Possible To-Dos:

- use smarter template e.g. from specific template-file.Rmd a-la usethis+whisker
- add use_readme_md() that adds the correspodining .md file
- Rework of @ilyaZar first implem

Issue #1011
- add more precise description for each argument in fill_desc()
- change some capital letters to lower case in fill_desc() comments
- fix missing tests for make_action_button
- possible bugfix for make_action_button
    - check with grepl instead of grep to avoid numeric(0) in
    if-statement which would make the corresponding test fail
    for button_6: class attribute present but not equal to
    "action-button" gives an error
ilyaZar and others added 28 commits February 28, 2024 15:38
build_readme causes an error if run non-interactively hence the skip_if_not(interactive()) is added in the first place

after deleting build_readme() the test passes non-interactively though
- to clearly show what the testing coverage is on each branch via the
  badge
- `README.Rmd` is altered to programatically retrieve the current git
  branch which automatically uses the correct coverage results from https://about.codecov.io/

Refs: #1086
- when CI rebuilds README.Rmd it should also use the badge of the git-branch so the codecov gets an update
@ColinFay ColinFay changed the base branch from dev to master April 10, 2024 15:30
@ColinFay ColinFay closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants