Allow multiple versions for external mismatch rule #131
Conversation
🦋 Changeset detectedLatest commit: 2034c99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This looks like it's the building blocks of what I'd need to implement #129 -- did I read this code correctly? |
|
@fbartho Yes, the current logic is to clamp the version back to the most commonly used one if it breaks the rule. We are thinking to change it to the highest version in the allowed list by default. Developers might want the highest allowed version most of the time. We can also save some migrations in the incremental upgrade if we install the highest version in the first place. |
|
That sounds great! I certainly vote for this PR and for changing the default, or adding an option. Not sure who is a contributor/maintainer here @cheesehary! Do you think anybody from @Thinkmill will approve/merge this? |
…sion fix the version to the closest allowed one
Fix semver range operations
|
@fbartho I'm not sure if anyone is reviewing/will approve this. |
The previous check only handled version ranges with a single leading character. To fix all other cases, we use the semver.minVersion fn instead to get the minimum version of a range and then return that.
…check MONO-136 fix semver range check
The previous check only handled version ranges with a single leading character. To fix all other cases, we use the semver.minVersion fn instead to get the minimum version of a range and then return that.
# Conflicts: # packages/cli/src/checks/EXTERNAL_MISMATCH.ts # packages/cli/src/checks/utils.ts
Upgrade from 0.19.1 to 0.21.4
#13 (comment)
We added an extra option to allow multiple versions for the external mismatch check. This allows to upgrade packages incrementally