Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In monorepo root, disallow dependencies in favor of devDependencies #236

Merged

Conversation

VanTanev
Copy link
Contributor

@VanTanev VanTanev commented Nov 4, 2024

closes #233

Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 5354fed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@manypkg/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VanTanev VanTanev force-pushed the root-dependencies-as-dev-dependencies branch from 01a45eb to 8cbebb9 Compare November 4, 2024 18:21
@VanTanev VanTanev force-pushed the root-dependencies-as-dev-dependencies branch from 8cbebb9 to 5354fed Compare November 4, 2024 18:23
@VanTanev
Copy link
Contributor Author

Anything in here that needs additional work?

@kachkaev
Copy link

👋 @Andarist! What are your thoughts on getting this one in?

Copy link
Collaborator

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have @emmatown chime in too

@emmatown emmatown merged commit 1a5ea55 into Thinkmill:main Nov 20, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@kachkaev
Copy link

kachkaev commented Nov 20, 2024

Awesome, thanks for getting this in folks! I can't wait to try a new version and replace dependencies with devDependencies in the root package.json 😅

manypkg is 💪 💪 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should there be an option to force devDependencies in root package.json?
4 participants