Skip to content

Commit

Permalink
support/scripts/genimage.sh: drop gzip compression
Browse files Browse the repository at this point in the history
Commit 6889056 (support/scripts/genimage.sh: support creating a bmap
image) added unconditional gzip compression of the genimage outputs if
bmap-tools is enabled, which is problematic for a number of reasons:

- The gzip invocation is not reproducable (E.G. does not use -n)

- The original file is removed, dropping the sparse info

- It hardcodes policy, E.G.  bmap supports a number of different compression
  algorithms / compression may not be desired for all images / different
  compression levels may be desired

So drop the compression step.  If desired, compression can be done with a
post-image script.

Signed-off-by: Peter Korsgaard <[email protected]>
Acked-by: TIAN Yuanhao <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
  • Loading branch information
jacmet authored and tpetazzoni committed Aug 30, 2024
1 parent 0b5feb5 commit 2bd1723
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion support/scripts/genimage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then
continue
fi
bmaptool create "${image_path}" -o "${image_path}.bmap"
gzip -c "${image_path}" > "${image_path}.gz"
done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2)
fi

0 comments on commit 2bd1723

Please sign in to comment.