Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from buildroot:master #364

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 20, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

lyctw and others added 3 commits November 19, 2024 22:00
I will lose access to my email next week, so hand
it over to Leo Yu-Chi Liang.

Signed-off-by: Yu Chien Peter Lin <[email protected]>
Reviewed-by: Leo Yu-Chi Liang <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
host-skopeo fail to build, using the commands:

    echo BR2_PACKAGE_HOST_SKOPEO=y >.config
    make olddefconfig
    make host-skopeo

This commit fixes the issue by selecting BR2_PACKAGE_HOST_GO
in the Config.in file.

Fixes:

    make: *** No rule to make target 'host-', needed by '/buildroot/output/build/host-go-1.23.2/.stamp_configured'.  Stop.

Reviewed-by: Yann E. MORIN <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
Commit 7b2a164 (package/go/go-bin: new host-go provider) broke the
case for prompt-less, host-only go packages, as the main host-go symbol
would not be selected.

This very same use-case was initially broken when the first go-src
provider was introduced with fa2536e (package/go: make host package
a virtual package), and subsequently fixed in 99a5d51 (package/go:
ensure there is a host-go provider), so 7b2a164 is causing a
regression of a fixed regression.

Fix that the very same way it was originally fixed.

Signed-off-by: Yann E. MORIN <[email protected]>
Cc: Yann E. MORIN <[email protected]>
Cc: Thomas Perale <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
@pull pull bot added the ⤵️ pull label Nov 20, 2024
@pull pull bot merged commit 575d971 into ThomasDevoogdt:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants