Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from buildroot:master #423

Merged
merged 6 commits into from
Jan 5, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 5, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

tpetazzoni and others added 6 commits January 4, 2025 18:49
Since the bump of xxhash from 0.8.2 to 0.8.3 in Buildroot commit
4b8f2f3, the host of host-php fails
when host-xxhash has been built before.

This is due to the fact that host-xxhash installs
HOST_DIR/include/xxhash.h, and the PHP code has an internal xxhash.h,
but due to the order of CFLAGS, the one from HOST_DIR/include/xxhash.h
gets included instead of the internal xxhash.h from PHP.

We initially tried to fix the order of CFLAGS, but that has proven to
be challenging within the complicated PHP build system. Then, we opted
for renaming the internal xxhash.h header of PHP, which we had
implemented and were about to submit upstream. But while rebasing this
fix on PHP's master, it turned out that PHP has an upstream commit
"Sync headers installation", merged for PHP 8.4.0, which has the side
effect of avoiding the issue. This commit moves xxhash.h into a
subfolder, so it gets included as #include "xxhash/xxhash.h" now,
which avoids the conflict with HOST_DIR/include/xxhash.h. Maybe not
the best fix, but it does fix the issue and it's upstream.

Since this patch is tweaking the PHP build system, we need to do the
equivalent of "autoreconf" but in the PHP world. It was already done
for the target package, we simply add the same logic for the host
package.

Fixes:

  http://autobuild.buildroot.net/results/583c054a564f90b8c884565070c5e17b43b89674/

Cc: James Hilliard <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
Since edk2-202408, ATF >= 2.12 is required for qemu aarch64 sbsa target
to support CPU topology information provided by edk2 firmware [1].

If ATF <= 2.11 is used, the boot will hand with the following error:

      sbsa_sip_smc_handler: unhandled SMC (0xc20000ca) (function id: 202)

In order to update edk2 package to a newer version, update ATF version
used by TestFwts to 2.12.

[1] ARM-software/arm-trusted-firmware@c891b4d

Cc: Julien Olivain <[email protected]>
Signed-off-by: Romain Naour <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
Since edk2-202408, ATF >= 2.12 is required for qemu aarch64 sbsa target
to support CPU topology information provided by edk2 firmware [1].

If ATF <= 2.11 is used, the boot will hand with the following error:

      sbsa_sip_smc_handler: unhandled SMC (0xc20000ca) (function id: 202)

In order to update edk2 package to a newer version, update ATF version
used by TestEdk2 to 2.12.

[1] ARM-software/arm-trusted-firmware@c891b4d

Cc: Julien Olivain <[email protected]>
Signed-off-by: Romain Naour <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
Since edk2-202408, ATF >= 2.12 is required for qemu aarch64 sbsa target
to support CPU topology information provided by edk2 firmware [1].

If ATF <= 2.11 is used, the boot will hand with the following error:

      sbsa_sip_smc_handler: unhandled SMC (0xc20000ca) (function id: 202)

In order to update edk2 package to a newer version, update ATF version
used by qemu_aarch64_sbsa_defconfig to 2.12.

[1] ARM-software/arm-trusted-firmware@c891b4d

Cc: Julien Olivain <[email protected]>
Signed-off-by: Romain Naour <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
Sync edk2-platforms with the last commit merged at the edk2 release
date (2024-11-22).

See:
https://github.com/tianocore/edk2/releases/tag/edk2-stable202411

Runtime tested with tests using EDK2 package: TestFwts, TestEdk2,
TestIso9660Grub2EFI, TestIso9660Grub2Hybrid, TestGrubi386EFI,
TestGrubX8664EFI, TestGrubAArch64EFI, TestGrubRiscV64EFI.

Runtime tested with defconfig using EDK2 package:
qemu_aarch64_sbsa_defconfig, qemu_riscv64_virt_efi_defconfig.

Cc: Julien Olivain <[email protected]>
Signed-off-by: Romain Naour <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
…ve edk2 download fix

Remove the download fix introduced by [1] now the edk2 git repository
has been fixed in version stable202411 [2].

[1] 47fc9e5.
[2] tianocore/edk2@95d8a1c

Cc: Julien Olivain <[email protected]>
Signed-off-by: Romain Naour <[email protected]>
Signed-off-by: Julien Olivain <[email protected]>
@pull pull bot added the ⤵️ pull label Jan 5, 2025
@pull pull bot merged commit 9ee173b into ThomasDevoogdt:master Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants